Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCHv2] Detect when instance is run or restarted by tarantoolctl.
Date: Wed, 4 Jul 2018 21:04:52 +0300	[thread overview]
Message-ID: <20180704180452.GA20825@chai> (raw)
In-Reply-To: <20180702144822.4860-1-sergepetrenko@tarantool.org>

* Serge Petrenko <sergepetrenko@tarantool.org> [18/07/02 17:54]:
> There are some hacks to know the instance was run by tarantoolctl,
> none of them are too reliable, though. This patch introduces 2
> environment variables set by tarantoolctl for the instance to
> know when it's being run or restarted.
> 
> Closes: #3215

Hi,

Please add a petition to docbot to the commit message.

Re TARANTOOL_RESTARTED, let's discuss this - I don't think 
this is going to address 
https://github.com/tarantool/tarantool/issues/3384
and gh-3215 is not asking for it.

So for now I would remove it from the patch.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2018-07-04 18:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 14:48 [tarantool-patches] " Serge Petrenko
2018-07-04 18:04 ` Konstantin Osipov [this message]
2018-07-05  6:58   ` [tarantool-patches] " Sergey Petrenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704180452.GA20825@chai \
    --to=kostja@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCHv2] Detect when instance is run or restarted by tarantoolctl.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox