Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2] box: allow vinyl_memory set to 0 in config
Date: Wed, 4 Jul 2018 17:23:46 +0300	[thread overview]
Message-ID: <20180704142346.6zwmshrzdi2xf7r3@esperanza> (raw)
In-Reply-To: <d9ae2a64-4ab3-e376-ef30-c7c96c0788bf@tarantool.org>

On Wed, Jul 04, 2018 at 05:11:10PM +0300, Sergey Petrenko wrote:
> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
> index b93a21f35..5608f6578 100755
> --- a/test/box-tap/cfg.test.lua
> +++ b/test/box-tap/cfg.test.lua
> @@ -6,7 +6,7 @@ local socket = require('socket')
>  local fio = require('fio')
>  local uuid = require('uuid')
>  local msgpack = require('msgpack')
> -test:plan(91)
> +test:plan(92)
> 
>  --------------------------------------------------------------------------------
>  -- Invalid values
> @@ -164,6 +164,13 @@ function run_script(code)
>      return res
>  end
> 
> +-- gh-3468: should allow box.cfg with vinyl_memory=0
> +code =[[
> +box.cfg{vinyl_memory=0}
> +os.exit(box.cfg.vinyl_memory == 0 and 0 or 1)
> +]]
> +test:is(run_script(code), 0, "actually set vinyl_memory to 0")

Looks good to me.

      reply	other threads:[~2018-07-04 14:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 13:23 Serge Petrenko
2018-07-04 13:37 ` Vladimir Davydov
2018-07-04 14:11   ` Sergey Petrenko
2018-07-04 14:23     ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704142346.6zwmshrzdi2xf7r3@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v2] box: allow vinyl_memory set to 0 in config' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox