Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] box: allow vinyl_memory set to 0 in config
Date: Wed, 4 Jul 2018 15:02:38 +0300	[thread overview]
Message-ID: <20180704120237.4zfmw3pzm24cdblk@esperanza> (raw)
In-Reply-To: <20180704113634.71324-1-sergepetrenko@tarantool.org>

On Wed, Jul 04, 2018 at 02:36:34PM +0300, Serge Petrenko wrote:
> In 1.9 it was possible to have a vinylless configuration with
> vinyl_memory=0, allow to do this in 1.10 by adjusting sanity
> checks for vinyl_memory and memtx_memory. Now banning only
> negative values.
> memtx_memory check was changed for consistency, trying to
> set memtx_memory to 0 fails anyways.
> 
> Closes: #3468
> ---
> https://github.com/tarantool/tarantool/compare/sergepetrenko/gh-3468-allow-0-vinyl-memory
> https://github.com/tarantool/tarantool/issues/3468
> 
> src/box/box.cc      | 8 ++++----
>  test/box/cfg.result | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)

Please add a test case checking that box.cfg.vinyl_memory can actually
be set to 0. Other than that looks OK.

  reply	other threads:[~2018-07-04 12:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 11:36 Serge Petrenko
2018-07-04 12:02 ` Vladimir Davydov [this message]
2018-07-04 12:56   ` Sergey Petrenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704120237.4zfmw3pzm24cdblk@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH] box: allow vinyl_memory set to 0 in config' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox