From: Serge Petrenko <sergepetrenko@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [tarantool-patches] [PATCH] box: allow vinyl_memory set to 0 in config
Date: Wed, 4 Jul 2018 14:36:34 +0300 [thread overview]
Message-ID: <20180704113634.71324-1-sergepetrenko@tarantool.org> (raw)
In 1.9 it was possible to have a vinylless configuration with
vinyl_memory=0, allow to do this in 1.10 by adjusting sanity
checks for vinyl_memory and memtx_memory. Now banning only
negative values.
memtx_memory check was changed for consistency, trying to
set memtx_memory to 0 fails anyways.
Closes: #3468
---
https://github.com/tarantool/tarantool/compare/sergepetrenko/gh-3468-allow-0-vinyl-memory
https://github.com/tarantool/tarantool/issues/3468
src/box/box.cc | 8 ++++----
test/box/cfg.result | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/box/box.cc b/src/box/box.cc
index dcbf52e10..7d6dfc8f6 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -495,9 +495,9 @@ box_check_wal_max_size(int64_t wal_max_size)
static int64_t
box_check_memtx_memory(int64_t memory)
{
- if (memory <= 0) {
+ if (memory < 0) {
tnt_raise(ClientError, ER_CFG, "memtx_memory",
- "must be greater than 0");
+ "must not be less than 0");
}
return memory;
}
@@ -505,9 +505,9 @@ box_check_memtx_memory(int64_t memory)
static int64_t
box_check_vinyl_memory(int64_t memory)
{
- if (memory <= 0) {
+ if (memory < 0) {
tnt_raise(ClientError, ER_CFG, "vinyl_memory",
- "must be greater than 0");
+ "must not be less than 0");
}
return memory;
}
diff --git a/test/box/cfg.result b/test/box/cfg.result
index 7604f61dc..6debb564b 100644
--- a/test/box/cfg.result
+++ b/test/box/cfg.result
@@ -240,11 +240,11 @@ box.cfg{memtx_memory = "100500"}
...
box.cfg{memtx_memory = -1}
---
-- error: 'Incorrect value for option ''memtx_memory'': must be greater than 0'
+- error: 'Incorrect value for option ''memtx_memory'': must not be less than 0'
...
box.cfg{vinyl_memory = -1}
---
-- error: 'Incorrect value for option ''vinyl_memory'': must be greater than 0'
+- error: 'Incorrect value for option ''vinyl_memory'': must not be less than 0'
...
box.cfg{vinyl = "vinyl"}
---
--
2.15.2 (Apple Git-101.1)
next reply other threads:[~2018-07-04 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 11:36 Serge Petrenko [this message]
2018-07-04 12:02 ` Vladimir Davydov
2018-07-04 12:56 ` Sergey Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704113634.71324-1-sergepetrenko@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] box: allow vinyl_memory set to 0 in config' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox