Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
	tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v1 1/1] lib/bitset: rename bitset structs
Date: Tue, 3 Jul 2018 19:25:56 +0300	[thread overview]
Message-ID: <20180703162556.hdoovac2e3nnd3t2@esperanza> (raw)
In-Reply-To: <da388eae-f592-006f-0cdd-72fbbc8e1039@tarantool.org>

On Tue, Jul 03, 2018 at 04:24:36PM +0300, Kirill Shcherbatov wrote:
> > I don't think you should rename any structures or functions defined in
> > memtx_bitset.c - they don't conflict and they are not related to struct
> > bitset.
> 
> Changes in memtx_bitset.{c, h} with my patch now.

Technically, the patch looks fine to me. Kostja, does renaming struct
bitset to tt_bitset in order to fix FreeBSD build make sense to you,
or you have a better idea in mind?

  reply	other threads:[~2018-07-03 16:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 10:29 Kirill Shcherbatov
2018-07-03 10:37 ` Vladimir Davydov
2018-07-03 12:24   ` [tarantool-patches] " Kirill Shcherbatov
2018-07-03 12:52     ` Vladimir Davydov
2018-07-03 13:24       ` Kirill Shcherbatov
2018-07-03 16:25         ` Vladimir Davydov [this message]
2018-07-03 17:10           ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703162556.hdoovac2e3nnd3t2@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kostja@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] Re: [PATCH v1 1/1] lib/bitset: rename bitset structs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox