From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: disallow returning many rows from subselect
Date: Tue, 3 Jul 2018 11:06:30 +0300 [thread overview]
Message-ID: <20180703080630.wmzzchios3j7u7pm@tarantool.org> (raw)
In-Reply-To: <ab693130051c0644aa0c4d309f232feeb54e7039.1529322436.git.kshcherbatov@tarantool.org>
Hello,
On 18 июн 14:55, Kirill Shcherbatov wrote:
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-2366-whith-select-subquery
> Issue: https://github.com/tarantool/tarantool/issues/2366
>
> To follow ANSI SQL standard we should dissallow returning
> multiple rows from subselects. To achieve this goal we have
> introduced some special Select SF_SingleRow flag that indicates
> the case of subselect having no client-defined LIMIT 1 to patch
> system implicit LIMIT 1 to be LIMIT 2 and generate some extra
> bytecode to HALT execution on reaching this restrict.
> The place of patching LIMIT expression iValue is a very special:
> this showld be done after simplifying epression tree(as this
> restrict could become useless), but before generating related
> bytecode.
I've checked in the patch into 2.0 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-07-03 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 11:55 [tarantool-patches] " Kirill Shcherbatov
2018-06-19 17:56 ` [tarantool-patches] " n.pettik
2018-06-27 15:30 ` [tarantool-patches] [PATCH v2 " Kirill Shcherbatov
2018-06-27 15:40 ` Kirill Shcherbatov
2018-06-28 13:04 ` [tarantool-patches] " n.pettik
2018-06-28 17:08 ` Kirill Shcherbatov
2018-06-29 13:15 ` n.pettik
2018-07-02 7:17 ` Kirill Shcherbatov
2018-07-02 8:45 ` n.pettik
2018-07-02 13:30 ` Vladislav Shpilevoy
2018-07-02 14:14 ` Kirill Shcherbatov
2018-07-02 14:42 ` Vladislav Shpilevoy
2018-07-02 14:52 ` Kirill Shcherbatov
2018-07-02 17:58 ` Vladislav Shpilevoy
2018-07-03 8:06 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703080630.wmzzchios3j7u7pm@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: disallow returning many rows from subselect' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox