From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 4/6] txn: do not require space id for nop requests
Date: Thu, 28 Jun 2018 13:35:40 +0300 [thread overview]
Message-ID: <20180628103540.h7l22phy5dibcbf3@esperanza> (raw)
In-Reply-To: <20180628102322.GA30029@chai>
On Thu, Jun 28, 2018 at 01:23:22PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/28 12:14]:
> > But txn_commit_nop() lives in txn.c. That's why I called it like that.
>
> Let's move it then.
That's going to look weird, because this function depends on internal
txn stuff. IMHO it all looks consistent as it is:
txn_begin_stmt - prepare DML request in transaction
txn_commit_stmt - commit DML request statement
txn_commit_nop - commit NOP request statement.
No?
next prev parent reply other threads:[~2018-06-28 10:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 16:10 [PATCH 0/6] Introduce replica local spaces Vladimir Davydov
2018-06-13 16:10 ` [PATCH 1/6] txn: remove unused C++ wrappers Vladimir Davydov
2018-06-27 17:08 ` Konstantin Osipov
2018-06-13 16:10 ` [PATCH 2/6] xrow: fix ret code on decode failure Vladimir Davydov
2018-06-27 17:29 ` Konstantin Osipov
2018-06-13 16:10 ` [PATCH 3/6] iproto: fix IPROTO_SERVER_IS_RO key code Vladimir Davydov
2018-06-27 17:48 ` Konstantin Osipov
2018-06-13 16:10 ` [PATCH 4/6] txn: do not require space id for nop requests Vladimir Davydov
2018-06-27 17:45 ` Konstantin Osipov
2018-06-28 9:13 ` Vladimir Davydov
2018-06-28 10:23 ` Konstantin Osipov
2018-06-28 10:35 ` Vladimir Davydov [this message]
2018-06-28 10:54 ` Konstantin Osipov
2018-06-28 11:10 ` Vladimir Davydov
2018-06-13 16:10 ` [PATCH 5/6] xrow: make NOP requests bodiless Vladimir Davydov
2018-06-27 17:49 ` Konstantin Osipov
2018-06-13 16:10 ` [PATCH 6/6] Introduce replica local spaces Vladimir Davydov
2018-06-13 21:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-27 18:24 ` Konstantin Osipov
2018-06-27 18:27 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628103540.h7l22phy5dibcbf3@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 4/6] txn: do not require space id for nop requests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox