From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 3/6] iproto: fix IPROTO_SERVER_IS_RO key code
Date: Wed, 27 Jun 2018 20:48:58 +0300 [thread overview]
Message-ID: <20180627174858.GI28358@chai> (raw)
In-Reply-To: <23a6cf92394dd7f5b8d32e5bfd548897ae0ead92.1528906027.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/13 20:40]:
> IPROTO_SERVER_IS_RO currently has code 0x07 and is defined in the header
> key section, which is wrong, because this key is only used in request
> body. Let's move it to the body section, where it belongs, and set its
> code to 0x29. This shouldn't break anything even if 0x07 is reused in
> future, because the two codes belong to different sections and hence are
> never parsed in the same function. Worst that can happen is we fail to
> bootstrap a node in the cluster if it is running a newer tarantool
> version.
Ugh, this is going to break things and we may have to revert, I
pushed to see how it goes.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-06-27 17:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 16:10 [PATCH 0/6] Introduce replica local spaces Vladimir Davydov
2018-06-13 16:10 ` [PATCH 1/6] txn: remove unused C++ wrappers Vladimir Davydov
2018-06-27 17:08 ` Konstantin Osipov
2018-06-13 16:10 ` [PATCH 2/6] xrow: fix ret code on decode failure Vladimir Davydov
2018-06-27 17:29 ` Konstantin Osipov
2018-06-13 16:10 ` [PATCH 3/6] iproto: fix IPROTO_SERVER_IS_RO key code Vladimir Davydov
2018-06-27 17:48 ` Konstantin Osipov [this message]
2018-06-13 16:10 ` [PATCH 4/6] txn: do not require space id for nop requests Vladimir Davydov
2018-06-27 17:45 ` Konstantin Osipov
2018-06-28 9:13 ` Vladimir Davydov
2018-06-28 10:23 ` Konstantin Osipov
2018-06-28 10:35 ` Vladimir Davydov
2018-06-28 10:54 ` Konstantin Osipov
2018-06-28 11:10 ` Vladimir Davydov
2018-06-13 16:10 ` [PATCH 5/6] xrow: make NOP requests bodiless Vladimir Davydov
2018-06-27 17:49 ` Konstantin Osipov
2018-06-13 16:10 ` [PATCH 6/6] Introduce replica local spaces Vladimir Davydov
2018-06-13 21:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-27 18:24 ` Konstantin Osipov
2018-06-27 18:27 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627174858.GI28358@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH 3/6] iproto: fix IPROTO_SERVER_IS_RO key code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox