From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: fix read iterator skips source after reading cache
Date: Wed, 27 Jun 2018 19:02:51 +0300 [thread overview]
Message-ID: <20180627160251.GB28358@chai> (raw)
In-Reply-To: <cb3491f472ccf3374248d5cdf87c6a6f2de67746.1529685755.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/23 08:30]:
> If a source is used on a read iteration (i.e. the key at which it is
> positioned is the next best match or, in terms of the read iterator
> implementation, its front_id matches the read iterator front_id), its
> history is cleaned up, see vy_read_iterator_apply_history(). This breaks
> the logic behind vy_read_src_is_behind(), which assumes that the history
> always points to the last used key. As a result, a source may be
> mistakenly skipped, as illustrated below:
Pushed.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
prev parent reply other threads:[~2018-06-27 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 16:53 Vladimir Davydov
2018-06-27 16:02 ` Konstantin Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627160251.GB28358@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH] vinyl: fix read iterator skips source after reading cache' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox