Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] socket: fix race between unix tcp server stop and start
Date: Wed, 27 Jun 2018 18:54:39 +0300	[thread overview]
Message-ID: <20180627155439.GA28358@chai> (raw)
In-Reply-To: <f59dbada53c120f89432acaad8395a02e7009cbb.1528724129.git.vdavydov.dev@gmail.com>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/11 23:57]:
> If called on a unix socket, bind(2) creates a new file, see unix(7).
> When we stop a unix tcp server, we should remove that file. Currently,
> we do it from the tcp server fiber, after the server loop is broken,
> which happens when the socket is closed, see tcp_server_loop(). This
> opens a time window for another tcp server to reuse the same path:
> 

Pushed.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

      reply	other threads:[~2018-06-27 15:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 14:03 Vladimir Davydov
2018-06-27 15:54 ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627155439.GA28358@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] socket: fix race between unix tcp server stop and start' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox