Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Ivan Ilyin <vanyail@yandex.ru>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1] sql: change of PRAGMA INDEX_INFO syntax
Date: Sun, 17 Jun 2018 23:06:30 +0300	[thread overview]
Message-ID: <20180617200630.azv3joe77q5nescj@tkn_work_nb> (raw)
In-Reply-To: <1528795940-13564-1-git-send-email-vanyail@yandex.ru>

Hi Ivan!

See my comments below.

WBR, Alexander Turenko.

On Tue, Jun 12, 2018 at 12:32:20PM +0300, Ivan Ilyin wrote:
> This change removes 'pragma index_xinfo' syntax. 'pragma index_info'
> now works as 'pragma index_xinfo' and also displays type of columns in
> index.
> 
> Fixes #3194
> ---

Don't forget to include branch name in the message to
tarantool-patches@.

TARGET=test job fails in CI for your branch: see [1]. It fails before
sql-tap suite and the fail does not related to your changes. But it is
your responsibility to check whether the fail is flaky (restarting this
job should make it green) and bring it into focus of your mentor if the
fail is persistent.

[1]: https://travis-ci.org/tarantool/tarantool/jobs/391176317

> diff --git a/src/box/sql/pragma.c b/src/box/sql/pragma.c
> index 9dab5a7..ec0dff3 100644
> --- a/src/box/sql/pragma.c
> +++ b/src/box/sql/pragma.c
> <...>
> +						const char *c_n;
> +						uint32_t id;
> +						struct coll *coll =
> +							sql_index_collation(pIdx, i, &id);
> +						if (coll != NULL)
> +							c_n = coll_by_id(id)->name;
> +						else
> +							c_n = "BINARY";
> +						enum sort_order sort_order;
> +						sort_order = sql_index_column_sort_order(pIdx,
> +											 i);
> +						enum field_type type = pIdx->pTable->
> +											def->fields[cnum].type;
> +						sqlite3VdbeMultiLoad(v, 1, "iisisis", i,
> +											cnum, cnum < 0 ? 0 :
> +											pIdx->pTable->def->
> +											fields[cnum].name,
> +											sort_order, c_n, i < mx,
> +											field_type_strs[type]);

Tab width is 8 symbols, please fix indent.

      reply	other threads:[~2018-06-17 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  9:32 [tarantool-patches] " Ivan Ilyin
2018-06-17 20:06 ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180617200630.azv3joe77q5nescj@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vanyail@yandex.ru \
    --subject='[tarantool-patches] Re: [PATCH v1] sql: change of PRAGMA INDEX_INFO syntax' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox