From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: fix vinyl/upgrade/fill.lua script
Date: Thu, 14 Jun 2018 11:21:07 +0300 [thread overview]
Message-ID: <20180614082107.w5pm6fqfdxabpuer@esperanza> (raw)
In-Reply-To: <20180613173912.GA5404@chai>
On Wed, Jun 13, 2018 at 08:39:12PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/13 13:42]:
> > Since commit 8f63d5d90 ("vinyl: fail transaction immediately if it does
> > not fit in memory"), vinyl won't trigger memory dump if the size of
> > memory needed by a transaction is greater than the memory limit, instead
> > it will fail the transaction immediately. This broke the aforementioned
> > script, which relied on this to trigger system-wide memory dump. Fix it
> > by reworking the dump trigger logic used by the script: now it tries to
> > insert two tuples, box.cfg.vinyl_memory / 2 size each, instead of one.
> >
> > Closes #3449
>
>
> > while box.stat.vinyl().quota.used > 0 do
> > fiber.sleep(0.1)
>
> Let's settle on 0.01 as standard fiber-loop-wait time in tests.
>
> Otherwise it's ok to push.
Fixed and pushed to 1.10
prev parent reply other threads:[~2018-06-14 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 9:44 Vladimir Davydov
2018-06-13 17:39 ` Konstantin Osipov
2018-06-14 8:21 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614082107.w5pm6fqfdxabpuer@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] test: fix vinyl/upgrade/fill.lua script' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox