From: Konstantin Osipov <kostja@tarantool.org> To: Vladimir Davydov <vdavydov.dev@gmail.com> Cc: tarantool-patches@freelists.org Subject: Re: [PATCH] test: fix vinyl/upgrade/fill.lua script Date: Wed, 13 Jun 2018 20:39:12 +0300 [thread overview] Message-ID: <20180613173912.GA5404@chai> (raw) In-Reply-To: <456b1a8ffd68ee945a20bd233f61a80f402a8953.1528882963.git.vdavydov.dev@gmail.com> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/13 13:42]: > Since commit 8f63d5d90 ("vinyl: fail transaction immediately if it does > not fit in memory"), vinyl won't trigger memory dump if the size of > memory needed by a transaction is greater than the memory limit, instead > it will fail the transaction immediately. This broke the aforementioned > script, which relied on this to trigger system-wide memory dump. Fix it > by reworking the dump trigger logic used by the script: now it tries to > insert two tuples, box.cfg.vinyl_memory / 2 size each, instead of one. > > Closes #3449 > while box.stat.vinyl().quota.used > 0 do > fiber.sleep(0.1) Let's settle on 0.01 as standard fiber-loop-wait time in tests. Otherwise it's ok to push. > end > + -- Wait for compaction to collect garbage. > + while dump_trigger.index.pk:stat().run_count > 1 do > + fiber.sleep(0.1) > + end > end > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-06-13 17:39 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-13 9:44 Vladimir Davydov 2018-06-13 17:39 ` Konstantin Osipov [this message] 2018-06-14 8:21 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180613173912.GA5404@chai \ --to=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH] test: fix vinyl/upgrade/fill.lua script' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox