From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove unnecessary def rebuild in endTable()
Date: Mon, 11 Jun 2018 10:56:38 +0300 [thread overview]
Message-ID: <20180611075638.r4ngkrvbe27lscvu@tarantool.org> (raw)
In-Reply-To: <6cd9fb15-8073-9398-57ef-cd9094181ca4@tarantool.org>
Hello,
On 07 июн 15:31, Vladislav Shpilevoy wrote:
> Thanks for the patch! LGTM.
>
> On 07/06/2018 14:24, Nikita Pettik wrote:
> > sqlite3EndTable() routine is called twice during table creation: firsly
> > after initial parsing alongside with generating VDBE program; secondly -
> > as a callback in order to add struct Table to internal table hash.
> > sqlite3EndTable() contains call of sql_table_def_rebuild() which in
> > turn copies space_def to malloc. However, it makes no sence to call
> > rebuild during the first stage, since this sample of struct Table will
> > be destroyed at the end of initial parsing and will be resurrected at
> > the second stage from the scratch.
I've checked the patch into 2.0 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-06-11 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 11:24 [tarantool-patches] " Nikita Pettik
2018-06-07 12:31 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-11 7:56 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611075638.r4ngkrvbe27lscvu@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove unnecessary def rebuild in endTable()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox