From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v2 0/2] Create bigrefs for tuples
Date: Sat, 9 Jun 2018 15:34:17 +0300 [thread overview]
Message-ID: <20180609123417.3es6j42p4kel36xr@esperanza> (raw)
In-Reply-To: <cover.1528544705.git.imeevma@gmail.com>
[ Below is a comment regarding our review process. Please take it into
account in future. No need to resend anything now. ]
Apparently, it's not v2 anymore, but rather v6. Please bump the version
every time you submit a new patch version. Also, according to our review
guideline, you need to:
- Say a few words about the patch set in the cover letter.
- Add hyperlinks to the GitHub issue and branch corresponding to your
patch set.
- Write a brief change log that outlines what have changed since the
version submitted last time.
You can read the guideline here:
https://tarantool.io/en/doc/1.9/dev_guide/developer_guidelines.html#how-to-submit-a-patch-for-review
Here's an example of a good cover letter:
https://www.freelists.org/post/tarantool-patches/PATCH-v2-05-vinyl-multipart-bloom-filter
On Sat, Jun 09, 2018 at 02:49:03PM +0300, imeevma@tarantool.org wrote:
> Mergen Imeev (1):
> box: create bigrefs for tuples
>
> Vladislav Shpilevoy (1):
> tuple: introduce bigref hints
>
> src/box/box.cc | 20 ++---
> src/box/errcode.h | 2 +-
> src/box/index.cc | 20 ++---
> src/box/lua/tuple.c | 5 +-
> src/box/port.c | 8 +-
> src/box/tuple.c | 182 ++++++++++++++++++++++++++++++++++++++++--
> src/box/tuple.h | 105 +++++++++---------------
> src/box/vinyl.c | 38 ++++-----
> test/box/misc.result | 39 +++++----
> test/box/select.result | 43 ++++++++--
> test/box/select.test.lua | 21 ++++-
> test/unit/CMakeLists.txt | 3 +
> test/unit/tuple_bigref.c | 174 ++++++++++++++++++++++++++++++++++++++++
> test/unit/tuple_bigref.result | 6 ++
> 14 files changed, 510 insertions(+), 156 deletions(-)
> create mode 100644 test/unit/tuple_bigref.c
> create mode 100644 test/unit/tuple_bigref.result
prev parent reply other threads:[~2018-06-09 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 11:49 imeevma
2018-06-09 11:49 ` [tarantool-patches] [PATCH v2 1/2] box: create " imeevma
2018-06-09 12:36 ` Vladimir Davydov
2018-06-09 11:49 ` [tarantool-patches] [PATCH v2 2/2] tuple: introduce bigref hints imeevma
2018-06-09 12:39 ` Vladimir Davydov
2018-06-09 12:34 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180609123417.3es6j42p4kel36xr@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v2 0/2] Create bigrefs for tuples' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox