Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v3 3/4] session: introduce binary box.session.push
Date: Fri, 8 Jun 2018 06:51:02 +0300	[thread overview]
Message-ID: <20180608035102.GE6866@chai> (raw)
In-Reply-To: <3c142fdd-fb7b-bd60-4615-f9152fd8b8c9@tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/06/07 23:59]:

> > My code review for this patch is on branch
> > box-session-push-kostja.
> > 
> > What still needs to be done:
> > 
> > - convert push.test to box-tap
> 
> I have removed assertions and left the test be output checking.
> Push test does many table members checking, and it is simpler to
> just output the tables.
> 
> Assertions were in a single place were a table contains 400 members.
> But ok, now I did it like in vinyl/select_consistency test.
> 
> > - think about alternatives which would preserve sync in a Lua
> >    routine. Looks like using an upvalue would do
> >    https://www.lua.org/pil/27.3.3.html
> 
> I had investigated it before you have recommended and before I
> started the patch. But ok, I have investigated it again, and
> wrote the simple patch, that shows upvalues to be unusable as
> sync storage. See the diff below and the explanation under the diff.

Vlad, I need to push the patch first and investigate this problem
second. I understand somebody wanted to not bother with the sync
in the ticket, but it is not a priority for me. 

Please revert fiber_sync() changes asap and update the tests, so
that I can push the patch. We can talk about fixing
box.session.sync() later. My problem with the patch is that you
make a partial fix (box.session.sync() is still broken) and use
fiber local storage for something that has little to do with a
fiber.

I'm sure there are acceptable ways to fix box.session.sync(). 
I'll be happy to discuss them once we've done with the current
patch.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2018-06-08  3:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 20:55 [tarantool-patches] [PATCH v3 0/4] box.session.push Vladislav Shpilevoy
2018-06-01 20:55 ` [tarantool-patches] [PATCH v3 1/4] session: introduce text box.session.push Vladislav Shpilevoy
2018-06-01 20:55 ` [tarantool-patches] [PATCH v3 2/4] session: enable box.session.push in local console Vladislav Shpilevoy
2018-06-01 20:55 ` [tarantool-patches] [PATCH v3 3/4] session: introduce binary box.session.push Vladislav Shpilevoy
2018-06-07 12:53   ` [tarantool-patches] " Konstantin Osipov
2018-06-07 17:02     ` Vladislav Shpilevoy
2018-06-08  3:51       ` Konstantin Osipov [this message]
2018-06-01 20:55 ` [tarantool-patches] [PATCH v3 4/4] netbox: introduce iterable future objects Vladislav Shpilevoy
2018-06-07 12:56   ` [tarantool-patches] " Konstantin Osipov
2018-06-07 17:02     ` Vladislav Shpilevoy
2018-06-08  3:52       ` Konstantin Osipov
2018-06-08 14:20         ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180608035102.GE6866@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH v3 3/4] session: introduce binary box.session.push' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox