From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v3 0/3] Allow to build indexes for vinyl spaces
Date: Thu, 7 Jun 2018 17:02:54 +0300 [thread overview]
Message-ID: <20180607140254.GA27029@chai> (raw)
In-Reply-To: <cover.1528368754.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/07 14:27]:
I pushed this patch set.
Vlad, if you have any comment re the last patch in the stack,
please write them here.
I believe we need to replace region_alloc with a new allocator
rather than wasting time on each individual case when copying
memory could be avoided.
Let's see how the community likes this feature.
> This patch set implements the ability to build secondary indexes for
> non-empty vinyl spaces. For implementation details, see patch 3.
>
> https://github.com/tarantool/tarantool/issues/1653
> https://github.com/tarantool/tarantool/commits/vy-allow-to-build-secondary-indexes
>
> - When building a new index, use original tuple LSNs instead
> of max LSN to the time.
This is a very good fix.
We only need to get rid of vylog to make the whole thing perfect,
and now we are a little closer to knowing how to do it.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
prev parent reply other threads:[~2018-06-07 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 10:56 Vladimir Davydov
2018-06-07 10:56 ` [PATCH v3 1/3] vinyl: do not yield on dump completion Vladimir Davydov
2018-06-07 10:56 ` [PATCH v3 2/3] vinyl: relax limitation imposed on run min/max lsn Vladimir Davydov
2018-06-07 10:56 ` [PATCH v3 3/3] vinyl: allow to build secondary index for non-empty space Vladimir Davydov
2018-06-07 14:02 ` Konstantin Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607140254.GA27029@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v3 0/3] Allow to build indexes for vinyl spaces' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox