Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 1/2] xlog: use ev_sleep instead of fiber_sleep for rate limiting
Date: Thu, 7 Jun 2018 16:11:52 +0300	[thread overview]
Message-ID: <20180607131152.GC23310@chai> (raw)
In-Reply-To: <20180604095133.iaxtdven3kjpuff5@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/04 23:48]:
> Anyway, yielding in xlog_write() may be unexpected from caller's pov,
> because this function is blocking (writes a file) and isn't supposed
> to yield. One usually hands it over to coio or a worker thread, where
> yielding is pointless.
> 
> > 
> > We will end up needing it for other things and it's nearly free.
> 
> What things?

Multiple things going on in the writer thread. Fiber-based
programming is a powerful concept, and we're already using cbus
for writer threads. Any kind of monitoring, collecting statistics,
periodic work is easier done when you have fiber runtime
available. 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2018-06-07 13:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 15:19 [PATCH 0/2] vinyl: allow to limit dump bandwidth Vladimir Davydov
2018-05-29 15:19 ` [PATCH 1/2] xlog: use ev_sleep instead of fiber_sleep for rate limiting Vladimir Davydov
2018-06-01 17:52   ` Konstantin Osipov
2018-06-04  9:51     ` Vladimir Davydov
2018-06-07 13:11       ` Konstantin Osipov [this message]
2018-05-29 15:19 ` [PATCH 2/2] vinyl: apply box.cfg.snap_io_rate_limit to dump/compaction Vladimir Davydov
2018-06-01 17:56   ` Konstantin Osipov
2018-06-04  9:55     ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607131152.GC23310@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH 1/2] xlog: use ev_sleep instead of fiber_sleep for rate limiting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox