[tarantool-patches] Re: [PATCH v3 3/4] session: introduce binary box.session.push

[Konstantin Osipov <kostja@tarantool.org>]

Hi,

My code review for this patch is on branch
box-session-push-kostja.

What still needs to be done:

- convert push.test to box-tap
- add a second argument to box.session.push() - which is reply
  sync, and test that it works. If the sync is not provided,
  session sync should be used.

There is follow up work, once this part of the patch is done:

- investigate whether we can use kharon to get rid discard_input messages
- think about alternatives which would preserve sync in a Lua
  routine. Looks like using an upvalue would do
  https://www.lua.org/pil/27.3.3.html

As a side note, this patch could well be split into 3:
- tx_fiber_init() refactoring
- kharon, and push implementation
- fiber_sync() and connection-multiplexing-safe implementation of
  box.session.sync()
 
Thanks,

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/06/02 02:09]:

> Closes #2677
> ---
>  src/box/iproto.cc          | 241 +++++++++++++++++++++++++++++++--------
>  src/box/iproto_constants.h |   3 +
>  src/box/lua/net_box.lua    | 104 ++++++++++++-----
>  src/box/xrow.c             |  12 ++
>  src/box/xrow.h             |  12 ++
>  src/fiber.h                |  14 ++-
>  test/box/net.box.result    |   8 +-
>  test/box/net.box.test.lua  |   8 +-
>  test/box/push.result       | 274 ++++++++++++++++++++++++++++++++++++++++++---
>  test/box/push.test.lua     | 148 ++++++++++++++++++++++--
>  10 files changed, 719 insertions(+), 105 deletions(-)
> 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov