From: Vladimir Davydov <vdavydov.dev@gmail.com> To: Konstantin Osipov <kostja@tarantool.org> Cc: tarantool-patches@freelists.org Subject: Re: [PATCH 2/2] vinyl: apply box.cfg.snap_io_rate_limit to dump/compaction Date: Mon, 4 Jun 2018 12:55:43 +0300 [thread overview] Message-ID: <20180604095543.mmbspvicrgeyleyh@esperanza> (raw) In-Reply-To: <20180601175628.GB15567@atlas> On Fri, Jun 01, 2018 at 08:56:28PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov <vdavydov.dev@gmail.com> [18/05/29 18:20]: > > > diff --git a/test/vinyl/snap_io_rate.test.lua b/test/vinyl/snap_io_rate.test.lua > > new file mode 100644 > > index 00000000..836bf537 > > --- /dev/null > > +++ b/test/vinyl/snap_io_rate.test.lua > > @@ -0,0 +1,38 @@ > > +fiber = require('fiber') > > +digest = require('digest') > > +test_run = require('test_run').new() > > + > > +MB = 1024 * 1024 > > +TUPLE_SIZE = 1024 > > +TUPLE_COUNT = 100 > > This test runs for 3.8 seconds on my laptop. > > You only need to run it for 0.2 seconds, definitely 1 second to > test the rate. xlog_write() throttles after writing a file for one second. So in order to make sure throttling works as expected, we need to run a test for a few seconds. To speed up the test, we need to rewrite the way throttling works, but I don't think it's worth it. > > Sorry for being painfully finicky about this, but I run tests > every day. > > If you hate this request, don't bother, this is a standalone test > and can run in parallel. Exactly.
prev parent reply other threads:[~2018-06-04 9:55 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-29 15:19 [PATCH 0/2] vinyl: allow to limit dump bandwidth Vladimir Davydov 2018-05-29 15:19 ` [PATCH 1/2] xlog: use ev_sleep instead of fiber_sleep for rate limiting Vladimir Davydov 2018-06-01 17:52 ` Konstantin Osipov 2018-06-04 9:51 ` Vladimir Davydov 2018-06-07 13:11 ` Konstantin Osipov 2018-05-29 15:19 ` [PATCH 2/2] vinyl: apply box.cfg.snap_io_rate_limit to dump/compaction Vladimir Davydov 2018-06-01 17:56 ` Konstantin Osipov 2018-06-04 9:55 ` Vladimir Davydov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180604095543.mmbspvicrgeyleyh@esperanza \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 2/2] vinyl: apply box.cfg.snap_io_rate_limit to dump/compaction' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox