Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 2/2] box: allow to specify the checkpoint to backup
Date: Wed, 30 May 2018 22:08:05 +0300	[thread overview]
Message-ID: <20180530190805.GG18850@atlas> (raw)
In-Reply-To: <09748147b73af6d2d828874f5178444a08dcfb94.1527669266.git.vdavydov.dev@gmail.com>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/05/30 11:45]:
> Even though we store last box.cfg.checkpoint_count checkpoints, we can
> only restore to the last one, because the backup API only allows to
> backup the last checkpoint. This patch adds an optional argument to
> box.backup.start() which specifies the index of the checkpoint to
> backup. If it is omitted or is 0, box.backup.start() will return files
> corresponding to the last checkpoint. If it is 1, it will back the
> previous checkpoint, and so on.
> 
> Closes #3410

Please open a documentation request.

The test case fails on my system, most likely once again because I
use symlinks.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2018-05-30 19:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  8:43 [PATCH 0/2] Extend backup API to backup any checkpoint Vladimir Davydov
2018-05-30  8:43 ` [PATCH 1/2] engine: constify vclock argument Vladimir Davydov
2018-05-30 19:05   ` Konstantin Osipov
2018-05-30  8:43 ` [PATCH 2/2] box: allow to specify the checkpoint to backup Vladimir Davydov
2018-05-30 19:08   ` Konstantin Osipov [this message]
2018-05-31  7:48     ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530190805.GG18850@atlas \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH 2/2] box: allow to specify the checkpoint to backup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox