From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/1] sql: IS is only applicable when dealing with NULL
Date: Wed, 30 May 2018 11:35:12 +0300 [thread overview]
Message-ID: <20180530083511.6sk32kf66b6esft5@tarantool.org> (raw)
In-Reply-To: <d3cbdf10-42d6-ee81-c830-f0ba85d2792c@tarantool.org>
On 24 мая 22:46, Vladislav Shpilevoy wrote:
> Thanks for the fixes! I force pushed my review fixes. Now LGTM.
>
> Kirill, please, do something.
I've committed your changes to 2.0 branch.
Mergen, could you pls in future obey SOP rules on brancgh naming?
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2018-05-30 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 11:26 [tarantool-patches] " Мерген Имеев
2018-05-18 11:55 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-18 16:10 ` [tarantool-patches] " Мерген Имеев
2018-05-18 21:37 ` Vladislav Shpilevoy
2018-05-23 14:30 ` Imeev Mergen
2018-05-24 11:52 ` Vladislav Shpilevoy
2018-05-24 14:00 ` Imeev Mergen
2018-05-24 19:46 ` Vladislav Shpilevoy
2018-05-30 8:35 ` Kirill Yukhin [this message]
2018-05-18 14:34 ` Konstantin Osipov
-- strict thread matches above, loose matches on Subject: below --
2018-05-16 13:50 [tarantool-patches] " Мерген Имеев
2018-05-16 18:52 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530083511.6sk32kf66b6esft5@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] sql: IS is only applicable when dealing with NULL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox