From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: allow any space symbols to be a white space
Date: Thu, 24 May 2018 17:23:18 +0300 [thread overview]
Message-ID: <20180524142318.beimzmewm5zyd2vy@tarantool.org> (raw)
In-Reply-To: <7cbf79d0-8242-4079-8641-1635a45e863d@tarantool.org>
Hello,
On 24 мая 14:09, Vladislav Shpilevoy wrote:
> LGTM.
Thanks, I've committed the patch into 2.0 branch.
--
Regards, Kirill Yukhin
>
> On 23/05/2018 17:05, Kirill Yukhin wrote:
> > Hi Vlad,
> > Thanks for review! My comments inlined.
> >
> > On 23 мая 13:29, Vladislav Shpilevoy wrote:
> > > Hello. Thanks for the fixes! I see, that you changed branch to
> > > kyukhin/gh-2371-utf8-spaces-check, right?
> > Nope, branch is the same. This one was for Travis checking.
> > Original branch contains updated patch, which in turn contains
> > update for CMakeLists.txt. I've removed this temporary branch.
prev parent reply other threads:[~2018-05-24 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 15:51 [tarantool-patches] " Kirill Yukhin
2018-05-22 18:06 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-23 5:15 ` Kirill Yukhin
2018-05-23 5:54 ` Kirill Yukhin
2018-05-23 10:29 ` Vladislav Shpilevoy
2018-05-23 14:05 ` Kirill Yukhin
2018-05-24 11:09 ` Vladislav Shpilevoy
2018-05-24 14:23 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524142318.beimzmewm5zyd2vy@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH] sql: allow any space symbols to be a white space' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox