From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 1/2] memtx: rework background garbage collection procedure
Date: Thu, 24 May 2018 09:13:35 +0300 [thread overview]
Message-ID: <20180524061335.o62p3hlubyb75mci@esperanza> (raw)
In-Reply-To: <20180523175655.GD4266@atlas>
On Wed, May 23, 2018 at 08:56:55PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/05/22 20:29]:
> > {
> > - index_def_delete(index->def);
> > + /*
> > + * Free index_def after destroying the index as
> > + * engine might still need it.
> > + */
>
> For what?
In this patch I rewrote the code of memtx tree/hash destruction so that
now they check if they are dealing with a primary index explicitly, i.e.
via index->def->iid, see memtx_{hash,tree}_index_destroy. I think it's
easier for understanding. I'll update the comment to reflect this.
>
> > + struct index_def *def = index->def;
> > index->vtab->destroy(index);
> > + index_def_delete(def);
> > }
>
> OK to push.
next prev parent reply other threads:[~2018-05-24 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 17:25 [PATCH v2 0/2] Follow-up on async memtx index cleanup Vladimir Davydov
2018-05-22 17:25 ` [PATCH v2 1/2] memtx: rework background garbage collection procedure Vladimir Davydov
2018-05-23 17:56 ` Konstantin Osipov
2018-05-24 6:13 ` Vladimir Davydov [this message]
2018-05-22 17:25 ` [PATCH v2 2/2] memtx: run garbage collection on demand Vladimir Davydov
2018-05-23 17:58 ` Konstantin Osipov
2018-05-24 6:15 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524061335.o62p3hlubyb75mci@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v2 1/2] memtx: rework background garbage collection procedure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox