From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/1] sql: fix out of time auto commit mode detection
Date: Tue, 22 May 2018 09:56:26 +0300 [thread overview]
Message-ID: <20180522065626.xln422smjfeedrvm@tarantool.org> (raw)
In-Reply-To: <72eccb80-83ec-bcda-56b0-8abe69f0cccb@tarantool.org>
Hello Vlad,
On 22 мая 00:46, Vladislav Shpilevoy wrote:
> Hello. Thanks for review!
>
> On 22/05/2018 00:45, Nikita Pettik wrote:
> > + * Once per execution time prepare the programm: detect
> >
> > Nitpicking: 'program'.
>
> @@ -5352,7 +5352,7 @@ case OP_Init: { /* jump */
> assert(pOp->p4.z==0 || strncmp(pOp->p4.z, "-" "- ", 3)==0);
> assert(pOp==p->aOp); /* Always instruction 0 */
> /*
> - * Once per execution time prepare the programm: detect
> + * Once per execution time prepare the program: detect
> * autocommit, create SQL specific transaction things. To
> >
> > LGTM.
I've checked you patch into 2.0 branch.
In future, could you pls name your branches according to SOP?
Please, see chapter `Submitting a patch` for details.
> > --
> > Nikita Pettik
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-05-22 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 21:33 [tarantool-patches] " Vladislav Shpilevoy
2018-05-21 21:45 ` [tarantool-patches] " Nikita Pettik
2018-05-21 21:46 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-22 6:56 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522065626.xln422smjfeedrvm@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] sql: fix out of time auto commit mode detection' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox