From: Konstantin Osipov <kostja@tarantool.org>
To: Konstantin Belyavskiy <k.belyavskiy@tarantool.org>
Cc: tarantool-patches@freelists.org, vdavydov@tarantool.org,
georgy@tarantool.org
Subject: Re: [PATCH 1/2] replication: do not delete relay on applier disconnect
Date: Mon, 21 May 2018 21:50:52 +0300 [thread overview]
Message-ID: <20180521185052.GA8516@atlas> (raw)
In-Reply-To: <9fa887ca5a8ea2b9d496a7bfd0d4c7a83da26ac8.1526921933.git.k.belyavskiy@tarantool.org>
* Konstantin Belyavskiy <k.belyavskiy@tarantool.org> [18/05/21 20:11]:
Both patches look good to me, but since you're deleting
relay->exiting, I would clear the WAL watcher before
fiber_join(&reader), to shorten the gap during which we try to
send unnecessary events to the client.
.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-05-21 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 17:07 [PATCH 0/2] replication: improve logging Konstantin Belyavskiy
2018-05-21 17:07 ` [PATCH 1/2] replication: do not delete relay on applier disconnect Konstantin Belyavskiy
2018-05-21 18:50 ` Konstantin Osipov [this message]
2018-05-21 17:07 ` [PATCH 2/2] replication: display downstream status at upstream Konstantin Belyavskiy
2018-05-22 7:07 ` [tarantool-patches] " Kirill Yukhin
2018-05-22 10:44 ` [tarantool-patches] Re: [tarantool-patches] " Konstantin Belyavskiy
2018-05-22 11:24 ` Kirill Yukhin
2018-05-29 16:44 ` Konstantin Osipov
2018-05-22 7:08 ` [tarantool-patches] [PATCH 0/2] replication: improve logging Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521185052.GA8516@atlas \
--to=kostja@tarantool.org \
--cc=georgy@tarantool.org \
--cc=k.belyavskiy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov@tarantool.org \
--subject='Re: [PATCH 1/2] replication: do not delete relay on applier disconnect' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox