From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 2/4] vinyl: fix lost key on dump completion
Date: Tue, 15 May 2018 22:27:15 +0300 [thread overview]
Message-ID: <20180515192715.j3w7t4vhq5r4n6x7@esperanza> (raw)
In-Reply-To: <20180515192043.GB24119@atlas>
On Tue, May 15, 2018 at 10:20:43PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/05/15 17:10]:
>
> I rebased the patch to 1.9, added a comment and pushed the patch.
>
> Once again, a separate unit test for this edge case would be
> greatly appreciated.
It's rather tricky to write a unit test for this as vy_scheduler depends
on a lot of things. However, this bug is triggered in ~90% cases by
vinyl/select_consistency functional test after the last patch in the
series is applied (and this one is reverted, apparently).
Thanks.
next prev parent reply other threads:[~2018-05-15 19:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 14:08 [PATCH 0/4] vinyl: fix crash in vinyl_iterator_secondary_next() Vladimir Davydov
2018-05-15 14:08 ` [PATCH 1/4] vinyl: fix EQ check in run iterator Vladimir Davydov
2018-05-15 19:05 ` Konstantin Osipov
2018-05-15 19:23 ` Vladimir Davydov
2018-05-15 14:08 ` [PATCH 2/4] vinyl: fix lost key on dump completion Vladimir Davydov
2018-05-15 19:20 ` Konstantin Osipov
2018-05-15 19:27 ` Vladimir Davydov [this message]
2018-05-15 14:08 ` [PATCH 3/4] vinyl: do not panic if secondary index is inconsistent with primary Vladimir Davydov
2018-05-15 14:08 ` [PATCH 4/4] test: improve vinyl/select_consistency Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515192715.j3w7t4vhq5r4n6x7@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 2/4] vinyl: fix lost key on dump completion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox