From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/4] Rework SQL transaction processing
Date: Fri, 11 May 2018 10:17:42 +0300 [thread overview]
Message-ID: <20180511071742.xxh4kgze3rqznrt4@tarantool.org> (raw)
In-Reply-To: <18ab40f4-4357-f2bd-9280-1069f936995b@tarantool.org>
Hello Nikita, Vlad,
On 07 мая 16:31, Vladislav Shpilevoy wrote:
> Hello. Thanks for review fixes! The whole patchset LGTM now.
>
> On 03/05/2018 21:49, Nikita Pettik wrote:
> > Branch: https://github.com/tarantool/tarantool/tree/np/rework-sql-transactions
> > Issue:
> > https://github.com/tarantool/tarantool/issues/3237
> > https://github.com/tarantool/tarantool/issues/3313
> > https://github.com/tarantool/tarantool/issues/3379
The patch set fails testing:
[026] sql/transitive-transactions.test.lua [ fail ]
[026]
[026] Test failed! Result content mismatch:
[033] sql/drop-table.test.lua [ pass ]
[026] --- sql/transitive-transactions.result Fri May 11 10:15:28 2018
[026] +++ sql/transitive-transactions.reject Fri May 11 10:15:53 2018
[026] @@ -107,19 +107,20 @@
[026] box.sql.execute('PRAGMA defer_foreign_keys = 1;')
[026] fk_defer();
[026] ---
[026] +- error: 'Operation is not permitted when there is an active transaction '
[026] ...
[026] box.space.CHILD:select();
[026] ---
[026] -- - [1, 2]
[026] +- []
[026] ...
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2018-05-11 7:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 18:49 [tarantool-patches] " Nikita Pettik
2018-05-03 18:49 ` [tarantool-patches] [PATCH 1/4] sql: remove OP_AutoCommit opcode Nikita Pettik
2018-05-04 14:12 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-05 19:14 ` n.pettik
2018-05-03 18:49 ` [tarantool-patches] [PATCH 2/4] sql: allow transitive Lua <-> SQL transactions Nikita Pettik
2018-05-04 14:12 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-05 19:14 ` n.pettik
2018-05-03 18:49 ` [tarantool-patches] [PATCH 3/4] sql: allow SAVEPOINT statement outside transaction Nikita Pettik
2018-05-04 14:12 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-05 19:15 ` n.pettik
2018-05-03 18:49 ` [tarantool-patches] [PATCH 4/4] sql: fix SAVEPOINT RELEASE statement Nikita Pettik
2018-05-04 14:12 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-05 19:16 ` n.pettik
2018-05-07 13:31 ` [tarantool-patches] Re: [PATCH 0/4] Rework SQL transaction processing Vladislav Shpilevoy
2018-05-11 7:17 ` Kirill Yukhin [this message]
2018-05-11 10:08 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511071742.xxh4kgze3rqznrt4@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/4] Rework SQL transaction processing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox