Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 3/3] rope: make rope library be C template using macros
Date: Tue, 8 May 2018 23:22:02 +0300	[thread overview]
Message-ID: <20180508202202.GC26928@atlas> (raw)
In-Reply-To: <bc66a5af002fbb30c977b41fa3ea97ff2ab6f2b7.1524868484.git.v.shpilevoy@tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/04/28 08:50]:
> Rope library stores alloc, split and free functions by pointer,
> that is a huge slog at performance. There is no reason, why the
> rope library can not become a template.

I believe you still should keep some "slowpath" code in rope.c -
smaller binary footprint is usually faster.

I'm not sure though it'd be easy to extract.

In any case I'd wait with pushing this patch until we see the
rest.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

      reply	other threads:[~2018-05-08 20:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 22:36 [tarantool-patches] [PATCH 0/3] Optimize and simplify some tuple_update things Vladislav Shpilevoy
2018-04-27 22:36 ` [tarantool-patches] [PATCH 1/3] vinyl: remove vy_apply_upsert_ops Vladislav Shpilevoy
2018-05-08 20:18   ` [tarantool-patches] " Konstantin Osipov
2018-04-27 22:36 ` [tarantool-patches] [PATCH 2/3] tuple_update: remove alloc and alloc_ctx args Vladislav Shpilevoy
2018-05-08 20:18   ` [tarantool-patches] " Konstantin Osipov
2018-04-27 22:36 ` [tarantool-patches] [PATCH 3/3] rope: make rope library be C template using macros Vladislav Shpilevoy
2018-05-08 20:22   ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508202202.GC26928@atlas \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH 3/3] rope: make rope library be C template using macros' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox