From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/3] vinyl: remove vy_apply_upsert_ops
Date: Tue, 8 May 2018 23:18:27 +0300 [thread overview]
Message-ID: <20180508201827.GA26928@atlas> (raw)
In-Reply-To: <37cca09133f09ebcc50b4dd7432271669471b04b.1524868484.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/04/28 08:50]:
> Function vy_apply_upsert_opts originaly appears in this commit:
> 5627e53bf020bf83b8f74d3d04b93047bdf221b4, where it is a
> refactored version of a sophia upsertion. But when a vy_stmt was
> introduced, vinyl_apply_upsert_ops works just like ordinary
> tuple_upsert_execute. Remove this useless wrapper.
> ---
> src/box/vy_upsert.c | 43 +++++--------------------------------------
> 1 file changed, 5 insertions(+), 38 deletions(-)
Pushed.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-05-08 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 22:36 [tarantool-patches] [PATCH 0/3] Optimize and simplify some tuple_update things Vladislav Shpilevoy
2018-04-27 22:36 ` [tarantool-patches] [PATCH 1/3] vinyl: remove vy_apply_upsert_ops Vladislav Shpilevoy
2018-05-08 20:18 ` Konstantin Osipov [this message]
2018-04-27 22:36 ` [tarantool-patches] [PATCH 2/3] tuple_update: remove alloc and alloc_ctx args Vladislav Shpilevoy
2018-05-08 20:18 ` [tarantool-patches] " Konstantin Osipov
2018-04-27 22:36 ` [tarantool-patches] [PATCH 3/3] rope: make rope library be C template using macros Vladislav Shpilevoy
2018-05-08 20:22 ` [tarantool-patches] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508201827.GA26928@atlas \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/3] vinyl: remove vy_apply_upsert_ops' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox