From: Alexander Turenko <alexander.turenko@tarantool.org> To: Gleb Skiba <gleb-skiba@mail.ru> Cc: kyukhin@tarantool.org, tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v3] Fix warnings Date: Mon, 7 May 2018 11:27:05 +0300 [thread overview] Message-ID: <20180507082704.5iqu7zsu4c72ya5j@tkn_work_nb> (raw) In-Reply-To: <1524822818-22641-1-git-send-email-gleb-skiba@mail.ru> Hi Gleb, I have one comment, see below. WBR, Alexander Turenko. On Fri, Apr 27, 2018 at 12:53:38PM +0300, Redacted sender "gleb-skiba" for DMARC wrote: > From: Gleb <gleb-skiba@mail.ru> > > Ensure -Werror -Wall set for the whole src/. > Fix warnings which have been found with -Werror and -Wall. > Add new build target RelWithDebInfoWError. > Change build target on RelWithDebInfoWError in CI. > > Fixes #3238 > --- > Issue from https://github.com/tarantool/tarantool/issues/3238. > Source from https://github.com/tarantool/tarantool/tree/gh-3238-check-warnings. > Changes in v3: > -add MAYBE_UNUSED > diff --git a/src/box/sql/alter.c b/src/box/sql/alter.c > index b30a973..a83beea 100644 > --- a/src/box/sql/alter.c > +++ b/src/box/sql/alter.c > @@ -149,7 +149,7 @@ sqlite3AlterFinishAddColumn(Parse * pParse, Token * pColDef) > Column *pCol; /* The new column */ > Expr *pDflt; /* Default value for the new column */ > sqlite3 *db; /* The database connection; */ > - Vdbe *v = pParse->pVdbe; /* The prepared statement under construction */ > + MAYBE_UNUSED Vdbe *v = pParse->pVdbe; /* The prepared statement under construction */ > struct session *user_session = current_session(); > > db = pParse->db; Too long line (more than 80 symbols).
prev parent reply other threads:[~2018-05-07 8:26 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-27 9:53 [tarantool-patches] " Redacted sender "gleb-skiba" for DMARC 2018-05-07 8:27 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180507082704.5iqu7zsu4c72ya5j@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=gleb-skiba@mail.ru \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v3] Fix warnings' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox