From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h
Date: Fri, 4 May 2018 14:06:21 +0300 [thread overview]
Message-ID: <20180504110620.mydvpvn35qso2wfu@tkn_work_nb> (raw)
In-Reply-To: <974e5a841431ec8b25124030c3ce4a9113279d10.1524955403.git.v.shpilevoy@tarantool.org>
Hi, Vlad!
One tiny comment here.
WBR, Alexander Turenko.
On Sun, Apr 29, 2018 at 01:45:10AM +0300, Vladislav Shpilevoy wrote:
> The issue #3290 was not only about upper/lower Lua functions, but
> about unicode comparison functions too. Actually, the issue
> requests upper/lower exactly to do string comparison, that can be
> done more quick with no garbage strings creation. For this
> Tarantool collations can be used.
>
> To be able to expose collations into Lua, the coll.h/.c,
> coll_def.h/.c and coll_cache.h/.c must be moved from 'box' static
> library into 'core' static library so that they will be built
> together with string utils. But they require 'stat' and
> 'box_error' libraries. The patch prepares the files going to be
> moved, so in the next patch they are just moved, with no changes.
> It saves commit history.
'together with string utils' -- no more relevant to the patchset part
above this commit?
next prev parent reply other threads:[~2018-05-04 11:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-28 22:45 [tarantool-patches] [PATCH v2 0/5] Expose ICU into Lua Vladislav Shpilevoy
2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 1/5] alter: fix assertion in collations alter Vladislav Shpilevoy
2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h Vladislav Shpilevoy
2018-05-04 11:06 ` Alexander Turenko [this message]
2018-05-04 12:05 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 3/5] Merge box_error, stat and collations into core library Vladislav Shpilevoy
2018-05-04 11:36 ` [tarantool-patches] " Alexander Turenko
2018-05-04 12:05 ` Vladislav Shpilevoy
2018-05-08 13:18 ` Konstantin Osipov
2018-05-10 21:06 ` Vladislav Shpilevoy
2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 4/5] Always store built-in collations in the cache Vladislav Shpilevoy
2018-05-08 13:20 ` [tarantool-patches] " Konstantin Osipov
2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 5/5] lua: introduce utf8 built-in globaly visible module Vladislav Shpilevoy
2018-05-04 22:33 ` [tarantool-patches] " Alexander Turenko
2018-05-04 23:32 ` Vladislav Shpilevoy
2018-05-05 0:18 ` Alexander Turenko
2018-05-05 0:24 ` Vladislav Shpilevoy
2018-05-05 0:38 ` Alexander Turenko
2018-05-05 0:45 ` Vladislav Shpilevoy
2018-05-08 13:21 ` Konstantin Osipov
2018-05-05 0:19 ` [tarantool-patches] Re: [PATCH v2 0/5] Expose ICU into Lua Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504110620.mydvpvn35qso2wfu@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox