From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>, Gleb Skiba <gleb-skiba@mail.ru>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes
Date: Wed, 25 Apr 2018 18:17:46 +0300 [thread overview]
Message-ID: <20180425151745.zanpo6opqsmh3dhz@tkn_work_nb> (raw)
In-Reply-To: <1524654044-17949-1-git-send-email-gleb-skiba@mail.ru>
LGTM. Nikita, can you look?
Gleb, why do you sent two v3 patches? Also there are no any list of
changes of this v3 in comparison to the previous v3. It is for you
information, no actions expected from you for now.
WBR, Alexander Turenko.
On Wed, Apr 25, 2018 at 02:00:44PM +0300, Redacted sender "gleb-skiba" for DMARC wrote:
> From: Gleb <gleb-skiba@mail.ru>
>
> Remove support of partial indexes.
> Add test which checks inaccessibility of partial index syntax.
> Delete usage of partial index from tests.
> They can be enabled after #2626.
>
> Fixes #2165
> ---
> Issue from https://github.com/tarantool/tarantool/issues/2165.
> Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes.
> Changes in v3:
> -return tests which use partial.
> -delete "WHERE" from returned tests.
> -correct syntax errors in commit
next prev parent reply other threads:[~2018-04-25 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 11:00 [tarantool-patches] " Redacted sender "gleb-skiba" for DMARC
2018-04-25 15:17 ` Alexander Turenko [this message]
2018-04-25 15:44 ` [tarantool-patches] " n.pettik
2018-04-26 9:02 ` Kirill Yukhin
2018-04-26 12:23 ` [tarantool-patches] " GLEB SKIBA
-- strict thread matches above, loose matches on Subject: below --
2018-04-24 18:39 [tarantool-patches] " Gleb
2018-04-25 9:22 ` [tarantool-patches] " Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425151745.zanpo6opqsmh3dhz@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=gleb-skiba@mail.ru \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox