From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Gleb Skiba <gleb-skiba@mail.ru>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes
Date: Wed, 25 Apr 2018 12:22:56 +0300 [thread overview]
Message-ID: <20180425092256.pwodcjuzivizztcw@tkn_work_nb> (raw)
In-Reply-To: <1524595147-7195-1-git-send-email-gleb-skiba@mail.ru>
Hi Gleb!
Firstly, don't add autogenerated files like parse.c under version
control.
Add a person you want to respond you into 'To' header and others
(including mailing list) in 'Cc'. Just sending a message to the mailing
list doesn't trigger any review processes.
Send a message with open email to allow direct reply you (not through
mailing list). Here your email is shown as dmarc-noreply@freelists.org.
Please, fix the patch and ask me for review again.
WBR, Alexander Turenko.
On Tue, Apr 24, 2018 at 09:39:07PM +0300, Gleb wrote:
> Remove support of partial indexes.
> Add test which checks inaccessibility of partial index syntax.
> Delete usage of partial index from tests.
> They can be enabled after #2626.
>
> Fixes #2165
> ---
> Issue from https://github.com/tarantool/tarantool/issues/2165.
> Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes.
> Changes in v3:
> -return tests which use partial.
> -delete "WHERE" from returned tests.
> -correct syntax errors in commit
next prev parent reply other threads:[~2018-04-25 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 18:39 [tarantool-patches] " Gleb
2018-04-25 9:22 ` Alexander Turenko [this message]
2018-04-25 11:00 Redacted sender "gleb-skiba" for DMARC
2018-04-25 15:17 ` [tarantool-patches] " Alexander Turenko
2018-04-25 15:44 ` n.pettik
2018-04-26 9:02 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425092256.pwodcjuzivizztcw@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=gleb-skiba@mail.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox