From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 3/3] iproto: allow to configure IPROTO_MSG_MAX
Date: Tue, 24 Apr 2018 11:04:13 +0300 [thread overview]
Message-ID: <20180424080413.wgvrscmg7epkmbek@esperanza> (raw)
In-Reply-To: <b9ae0e94-daf4-9def-42e2-fdb15d7d8674@tarantool.org>
On Mon, Apr 23, 2018 at 08:00:13PM +0300, Vladislav Shpilevoy wrote:
> > > + if (cfg_msg.need_update_uri) {
> > > + if (evio_service_is_active(&binary))
> > > + evio_service_stop(&binary);
> > > + if (cfg_msg.uri != NULL)
> > > + evio_service_bind(&binary, cfg_msg.uri);
> > > + }
> > > + if (cfg_msg.need_update_msg_max) {
> > > + cpipe_set_max_input(&tx_pipe,
> > > + cfg_msg.iproto_msg_max / 2);
> > > + int old = iproto_msg_max;
> > > + iproto_msg_max = cfg_msg.iproto_msg_max;
> > > + if (old < iproto_msg_max)
> > > + iproto_resume();
> > > + }
> >
> > This is a matter of personal taste, but I'd prefer to not introduce
> > these extra flags, i.e.
>
> It is not possible for URI, because URI == NULL is possible update. So
> for URI the flag is necessary. For msg_max I added this for unifying. If you
> want, I can remove need_update_msg_max. Must I do it?
No need then. Leave it as is for consistency.
prev parent reply other threads:[~2018-04-24 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 22:52 [PATCH 0/3] " Vladislav Shpilevoy
[not found] ` <cover.1524264646.git.v.shpilevoy@tarantool.org>
2018-04-20 22:52 ` [PATCH 1/3] iproto: rename iproto_bind_msg to iproto_cfg_msg Vladislav Shpilevoy
2018-04-23 11:22 ` Vladimir Davydov
2018-04-23 17:00 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-20 22:52 ` [PATCH 2/3] iproto: fix error with input discarding Vladislav Shpilevoy
2018-04-23 11:20 ` Vladimir Davydov
2018-04-20 22:52 ` [PATCH 3/3] iproto: allow to configure IPROTO_MSG_MAX Vladislav Shpilevoy
2018-04-23 11:34 ` Vladimir Davydov
2018-04-23 17:00 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-24 8:04 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424080413.wgvrscmg7epkmbek@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] Re: [PATCH 3/3] iproto: allow to configure IPROTO_MSG_MAX' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox