From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 2/3] iproto: fix error with input discarding
Date: Mon, 23 Apr 2018 14:20:16 +0300 [thread overview]
Message-ID: <20180423112016.uxpkvfoqqaz7xtvo@esperanza> (raw)
In-Reply-To: <c738f35dd5b7ba4fd29a0a2f9c16a4527a058052.1524264646.git.v.shpilevoy@tarantool.org>
On Sat, Apr 21, 2018 at 01:52:10AM +0300, Vladislav Shpilevoy wrote:
> Long-polling request has a feature allowing to discard an input
> buffer in a connection before the main request is finished.
>
> Before the patch discard just calls iproto_resume() trying to
> notify libev, that is can get new data. But is makes no sense,
> because iproto_resume() continues only connections stopped due
> to reached limit of maximal requests in fly, but not connections
> whose buffer is overflowed. Such stopped connections can be
> continued only after a request is complete.
>
> To continue read from the connection whose buffer was freed by
> discarding long-poll it is necessary to explicitly feed to it
> EV_READ event. On this event iproto_connection_on_input will read
> a blocked data if it exists.
> ---
> src/box/iproto.cc | 5 +-
> test/box/request_limit.result | 114 ++++++++++++++++++++++++++++++++++++++++
> test/box/request_limit.test.lua | 63 ++++++++++++++++++++++
> 3 files changed, 180 insertions(+), 2 deletions(-)
> create mode 100644 test/box/request_limit.result
> create mode 100644 test/box/request_limit.test.lua
Ack
next prev parent reply other threads:[~2018-04-23 11:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 22:52 [PATCH 0/3] iproto: allow to configure IPROTO_MSG_MAX Vladislav Shpilevoy
[not found] ` <cover.1524264646.git.v.shpilevoy@tarantool.org>
2018-04-20 22:52 ` [PATCH 1/3] iproto: rename iproto_bind_msg to iproto_cfg_msg Vladislav Shpilevoy
2018-04-23 11:22 ` Vladimir Davydov
2018-04-23 17:00 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-20 22:52 ` [PATCH 2/3] iproto: fix error with input discarding Vladislav Shpilevoy
2018-04-23 11:20 ` Vladimir Davydov [this message]
2018-04-20 22:52 ` [PATCH 3/3] iproto: allow to configure IPROTO_MSG_MAX Vladislav Shpilevoy
2018-04-23 11:34 ` Vladimir Davydov
2018-04-23 17:00 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-24 8:04 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423112016.uxpkvfoqqaz7xtvo@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [PATCH 2/3] iproto: fix error with input discarding' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox