From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/1] console: on '\set delimiter' return default delimiter
Date: Sat, 21 Apr 2018 11:23:10 +0300 [thread overview]
Message-ID: <20180421082310.dryebmqi3srdi42c@tarantool.org> (raw)
In-Reply-To: <8c2204b2-a801-2c1c-c75f-22f4142ad19e@tarantool.org>
Hello Vlad,
On 20 апр 11:41, Vladislav Shpilevoy wrote:
> On 20/04/2018 08:16, Kirill Yukhin wrote:
> > Hello Vlad,
> > On 19 апр 18:46, Vladislav Shpilevoy wrote:
> > > When a user changes delimiter, he can not return to a
> > > default one using '\set delimiter' - it is fixed here.
> > >
> > > Closed #3359
> >
> > Is it possible to add a regression test?
>
> I tried, and unfortunately it works in interactive console only, on that a test
> can not be written. In remote console delimiter can not be changed.
Okay then. I've committed your patch to 2.1 branch
>
> >
> > -- Regards, Kirill Yukhin
> >
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-04-21 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 15:46 [tarantool-patches] " Vladislav Shpilevoy
2018-04-20 5:16 ` [tarantool-patches] " Kirill Yukhin
2018-04-20 8:41 ` Vladislav Shpilevoy
2018-04-21 8:23 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421082310.dryebmqi3srdi42c@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] console: on '\''\set delimiter'\'' return default delimiter' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox