[tarantool-patches] [PATCH 1/1] console: on '\set delimiter' return default delimiter

[tarantool-patches] [PATCH 1/1] console: on '\set delimiter' return default delimiter

[Vladislav Shpilevoy]

When a user changes delimiter, he can not return to a
default one using '\set delimiter' - it is fixed here.

Closed #3359
---
Issue: https://github.com/tarantool/tarantool/issues/3359
Branch: https://github.com/tarantool/tarantool/tree/gh-3359-fix-set-delimiter

 src/box/lua/console.lua | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/box/lua/console.lua b/src/box/lua/console.lua
index 753429967..63ec34078 100644
--- a/src/box/lua/console.lua
+++ b/src/box/lua/console.lua
@@ -74,6 +74,7 @@ local function set_delimiter(storage, value)
     if console ~= nil and console.delimiter == '$EOF$' then
         return error('Can not install delimiter for net box sessions')
     end
+    value = value or ''
     return delimiter(value)
 end
 
-- 
2.15.1 (Apple Git-101)

[tarantool-patches] Re: [PATCH 1/1] console: on '\set delimiter' return default delimiter

[Kirill Yukhin]

Hello Vlad,
On 19 апр 18:46, Vladislav Shpilevoy wrote:
> When a user changes delimiter, he can not return to a
> default one using '\set delimiter' - it is fixed here.
> 
> Closed #3359

Is it possible to add a regression test?

-- Regards, Kirill Yukhin

[tarantool-patches] Re: [PATCH 1/1] console: on '\set delimiter' return default delimiter

[Vladislav Shpilevoy]

On 20/04/2018 08:16, Kirill Yukhin wrote:
> Hello Vlad,
> On 19 апр 18:46, Vladislav Shpilevoy wrote:
>> When a user changes delimiter, he can not return to a
>> default one using '\set delimiter' - it is fixed here.
>>
>> Closed #3359
> 
> Is it possible to add a regression test?

I tried, and unfortunately it works in interactive console only, on that a test
can not be written. In remote console delimiter can not be changed.

> 
> -- Regards, Kirill Yukhin
> 

[tarantool-patches] Re: [PATCH 1/1] console: on '\set delimiter' return default delimiter

[Kirill Yukhin]

Hello Vlad,

On 20 апр 11:41, Vladislav Shpilevoy wrote:
> On 20/04/2018 08:16, Kirill Yukhin wrote:
> > Hello Vlad,
> > On 19 апр 18:46, Vladislav Shpilevoy wrote:
> > > When a user changes delimiter, he can not return to a
> > > default one using '\set delimiter' - it is fixed here.
> > > 
> > > Closed #3359
> > 
> > Is it possible to add a regression test?
> 
> I tried, and unfortunately it works in interactive console only, on that a test
> can not be written. In remote console delimiter can not be changed.
Okay then. I've committed your patch to 2.1 branch


> 
> > 
> > -- Regards, Kirill Yukhin
> >

--
Regards, Kirill Yukhin