From: Alexander Turenko <alexander.turenko@tarantool.org> To: Nikita Pettik <korablev@tarantool.org> Cc: tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v2] Fix warnings Date: Wed, 18 Apr 2018 15:13:02 +0300 [thread overview] Message-ID: <20180418121302.tnwnkidle3ihyka7@tkn_work_nb> (raw) In-Reply-To: <1523541010-7659-1-git-send-email-gleb-skiba@mail.ru> Hi Gleb! LGTM. Nikita, can you see the patch? WBR, Alexander Turenko. On Thu, Apr 12, 2018 at 04:50:10PM +0300, Gleb wrote: > Ensure -Werror -Wall set for the whole src/. > Fix warnings which have been find with -Werror and -Wall. > Add new building target RelWithDebInfoWError. > Change building target on RelWithDebInfoWError in CI. > > Fixes #3238 > --- > Issue from https://github.com/tarantool/tarantool/issues/3238. > Source from https://github.com/tarantool/tarantool/tree/gh-3238-check-warnings. > .travis.mk | 4 ++-- > cmake/compiler.cmake | 8 +++++++- > src/box/space_def.c | 2 ++ > src/box/sql/CMakeLists.txt | 3 --- > src/box/sql/alter.c | 1 + > src/box/sql/insert.c | 4 +++- > src/box/sql/pragma.c | 4 ++-- > src/box/vy_read_iterator.c | 2 +- > src/box/xrow.c | 10 +++++++--- > src/httpc.c | 2 +- > src/lua/init.c | 3 ++- > src/say.c | 7 +++++-- > 12 files changed, 33 insertions(+), 17 deletions(-) > case SAY_LOGGER_BOOT: > { > ssize_t r = safe_write(STDERR_FILENO, buf, total); > (void) r; /* silence gcc warning */ > + > break; > } > default: > -- > 2.7.4 This change (extra empty line) is redundant.
next prev parent reply other threads:[~2018-04-18 12:12 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-12 13:50 [tarantool-patches] " Gleb 2018-04-18 12:13 ` Alexander Turenko [this message] 2018-04-23 17:08 Gleb 2018-04-23 17:37 ` [tarantool-patches] " n.pettik 2018-04-26 6:38 ` Kirill Yukhin 2018-09-21 12:35 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180418121302.tnwnkidle3ihyka7@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2] Fix warnings' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox