Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Ilya Markov <imarkov@tarantool.org>
Cc: georgy@tarantool.org, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [wal 1/1] wal: Update request header after sequence update
Date: Wed, 18 Apr 2018 14:47:31 +0300	[thread overview]
Message-ID: <20180418114731.r2oetxab4md62wo2@esperanza> (raw)
In-Reply-To: <c582937d2c9698cc2b63ec6895a78e45410b90aa.1523950414.git.imarkov@tarantool.org>

On Tue, Apr 17, 2018 at 10:39:16AM +0300, Ilya Markov wrote:
> When tuple in insert/replace request has NULL value
> in the field incremented by sequence,
> request body is changed, NULL is replaced by value taken from
> sequence.
> But request header is not updated.
> So Redo log, which takes body from header if header exists,
> writes the old version of request to wal.
> 
> Fixed this with updating header value after handling the sequence.
> 
> Closes #3247
> ---
> branch gh-3247-wrong-sequence-primary-index
> 
>  src/box/request.c              |  7 +++++
>  test/replication/misc.result   | 66 ++++++++++++++++++++++++++++++++++++++++++
>  test/replication/misc.test.lua | 21 ++++++++++++++
>  3 files changed, 94 insertions(+)

Pushed to 1.9.

      parent reply	other threads:[~2018-04-18 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  7:39 Ilya Markov
2018-04-18  7:10 ` [tarantool-patches] " Georgy Kirichenko
2018-04-18 11:47 ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418114731.r2oetxab4md62wo2@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=georgy@tarantool.org \
    --cc=imarkov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [wal 1/1] wal: Update request header after sequence update' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox