From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: use collation pointers instead of names
Date: Wed, 18 Apr 2018 08:42:21 +0300 [thread overview]
Message-ID: <20180418054221.qsc3czyt2ilrt5lt@tarantool.org> (raw)
In-Reply-To: <23455f13-95ed-40b8-de72-610b1e9fba19@tarantool.org>
Hello Vlad,
On 17 апр 21:06, Vladislav Shpilevoy wrote:
> Hello. Thanks for fixes, but you did not all of them. I
> pushed my fixes as a separate commit on your branch. Please,
> look at them, squash into your commit, and then the patch
> will be ok for me.
Thanks. I've squashed your changes in and committed
final patch to 2.1 branch.
--
Regards, Kirill Yukhin
> On 17/04/2018 08:35, Kirill Yukhin wrote:
> > Before the change SQL FE used collation names to refer to
> > collations. Main data structures were using names as well.
> > The patch fixes that and uses explicit pointers to Tarantool's
> > `struct coll` during code gen and inside data structures.
> >
> > Closes #3205
next prev parent reply other threads:[~2018-04-18 5:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 7:56 [tarantool-patches] [PATCH 0/2] sql: replace KeyInfo w/ key_def in SQL front-end Kirill Yukhin
2018-05-08 7:56 ` [tarantool-patches] [PATCH 1/2] sql: introduce sort order to key_part/key_part_def Kirill Yukhin
2018-05-08 16:02 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-10 13:01 ` Kirill Yukhin
2018-05-08 7:56 ` [tarantool-patches] [PATCH] sql: use collation pointers instead of names Kirill Yukhin
2018-04-17 18:06 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-18 5:42 ` Kirill Yukhin [this message]
2018-05-08 7:59 ` Kirill Yukhin
2018-05-08 7:56 ` [tarantool-patches] [PATCH 2/2] sql: replace KeyInfo with key_def Kirill Yukhin
2018-05-08 16:02 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-10 12:59 ` Kirill Yukhin
2018-05-11 11:22 ` Vladislav Shpilevoy
2018-05-11 12:56 ` Kirill Yukhin
2018-05-11 19:05 ` Vladislav Shpilevoy
2018-05-14 11:40 ` Kirill Yukhin
-- strict thread matches above, loose matches on Subject: below --
2018-04-13 8:05 [tarantool-patches] [PATCH] sql: use collation pointers instead of names Kirill Yukhin
2018-04-16 13:43 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418054221.qsc3czyt2ilrt5lt@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH] sql: use collation pointers instead of names' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox