From: Kirill Yukhin <kyukhin@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] Remove autogenerated files
Date: Tue, 17 Apr 2018 11:58:10 +0300 [thread overview]
Message-ID: <20180417085810.bkmbzcpsk4w2gvao@tarantool.org> (raw)
In-Reply-To: <1141305d49839770c3951674c47a8ae2cb303c62.1523167474.git.alexander.turenko@tarantool.org>
Hello Alex!
Overall approach LGTM.
The only input I have here: could you pls put all generated
files into build directory. This will allow OOB to retain source
dir in virgin pure state.
--
Regards, Kirill Yukhin
On 08 апр 11:31, Alexander Turenko wrote:
> Rewrote TCL scripts as posix shell ones, enabled SQL_MAINTAINER_MODE
> commands unconditionally.
>
> Fixes #3183.
next prev parent reply other threads:[~2018-04-17 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 8:31 [tarantool-patches] " Alexander Turenko
2018-04-17 8:58 ` Kirill Yukhin [this message]
2018-04-18 11:45 ` [tarantool-patches] [PATCH v2] " Alexander Turenko
2018-04-22 5:01 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417085810.bkmbzcpsk4w2gvao@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] Remove autogenerated files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox