From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Belyavskiy <k.belyavskiy@tarantool.org>
Cc: georgy@tarantool.org, tarantool-patches@freelists.org
Subject: Re: [PATCH] replication: automatic skip duplicating rows in replication
Date: Fri, 13 Apr 2018 16:46:34 +0300 [thread overview]
Message-ID: <20180413134634.qfol5djszcvehxro@esperanza> (raw)
In-Reply-To: <20180413134412.20737-1-k.belyavskiy@tarantool.org>
On Fri, Apr 13, 2018 at 04:44:12PM +0300, Konstantin Belyavskiy wrote:
> ticket: https://github.com/tarantool/tarantool/issues/3270
> branch: https://github.com/tarantool/tarantool/compare/gh-3270-add-skip-conflict-row-option
>
> In case of attempting to insert a duplicate key, an error ER_TUPLE_FOUND
> occured, which led to disconnect.
> Introduce new oftion: 'replication_skip_conflict', if set, then error of
> this type will be ignored.
>
> Closes #3270
> ---
> src/box/applier.cc | 15 +++-
> src/box/lua/load_cfg.lua | 3 +
> test/app-tap/init_script.result | 45 ++++++------
> test/box/admin.result | 2 +
> test/box/cfg.result | 4 ++
> test/replication/skip_conflict_row.result | 105 ++++++++++++++++++++++++++++
> test/replication/skip_conflict_row.test.lua | 37 ++++++++++
> 7 files changed, 188 insertions(+), 23 deletions(-)
> create mode 100644 test/replication/skip_conflict_row.result
> create mode 100644 test/replication/skip_conflict_row.test.lua
Looks OK to me.
next prev parent reply other threads:[~2018-04-13 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 13:44 Konstantin Belyavskiy
2018-04-13 13:46 ` Vladimir Davydov [this message]
2018-04-18 12:30 ` Vladimir Davydov
2018-04-28 20:13 ` [tarantool-patches] " Konstantin Osipov
-- strict thread matches above, loose matches on Subject: below --
2018-04-12 11:01 Konstantin Belyavskiy
2018-04-13 8:23 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413134634.qfol5djszcvehxro@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=k.belyavskiy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] replication: automatic skip duplicating rows in replication' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox