From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Belyavskiy <k.belyavskiy@tarantool.org>
Cc: georgy@tarantool.org, tarantool-patches@freelists.org
Subject: Re: [PATCH v2] replication: fix bug with zero replication_connect_quorum
Date: Mon, 9 Apr 2018 17:07:33 +0300 [thread overview]
Message-ID: <20180409140733.j4tfgetd65qaj2g6@esperanza> (raw)
In-Reply-To: <20180409103530.21415-1-k.belyavskiy@tarantool.org>
The patch looks good to me.
On Mon, Apr 09, 2018 at 01:35:30PM +0300, Konstantin Belyavskiy wrote:
> If 'box.cfg.read_only' is false, 'replication' defines at least one
> replica (other than itself), but they are not available at the time
> of box.cfg execution and replication_connect_quorum is set to zero,
> master displays 'orphan' status instead of 'running' since logic
> which cnange this state is executed only after successfull connection.
>
> Changes in v2:
> Change test to @locker version.
>
> ticket: https://github.com/tarantool/tarantool/issues/3278
> branch: https://github.com/tarantool/tarantool/compare/gh-3278-fix-bug-with-zero-replication-connect-quorum
This should go after --- below (it is ignored by git-am then).
>
> Closes #3278
> ---
> src/box/replication.cc | 8 +++--
> test/replication/quorum.result | 66 ++++++++++++++++++++++++++++++++++
> test/replication/quorum.test.lua | 22 ++++++++++++
> test/replication/replica_no_quorum.lua | 11 ++++++
> 4 files changed, 105 insertions(+), 2 deletions(-)
> create mode 100644 test/replication/replica_no_quorum.lua
prev parent reply other threads:[~2018-04-09 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:35 Konstantin Belyavskiy
2018-04-09 14:07 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409140733.j4tfgetd65qaj2g6@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=k.belyavskiy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v2] replication: fix bug with zero replication_connect_quorum' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox