From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 1/1] identifier: do not use ICU UConverter for checks
Date: Fri, 6 Apr 2018 16:53:02 +0300 [thread overview]
Message-ID: <20180406135302.fhv6kn5e5k7v2gvk@esperanza> (raw)
In-Reply-To: <9c79f4be5957793acf8938387d9108e7b976c1b8.1522845248.git.v.shpilevoy@tarantool.org>
This doesn't work on EL6/7 and Debian Wheezy - check out travis.
https://travis-ci.org/tarantool/tarantool/builds/362116299?utm_source=github_status&utm_medium=notification
On Wed, Apr 04, 2018 at 03:35:41PM +0300, Vladislav Shpilevoy wrote:
> I makes no sense to create a converter, when there is
> nothing to convert. To check an identifier it is
> enough to use stateless ICU macros: U8_NEXT_OR_FFFD,
> that also allows to eliminate 0xFFFD symbol as a
> special one - this macros returns this code on any
> error, or when it is actually this symbol.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/identifier-do-not-use-uconverter
>
> src/box/box.cc | 2 --
> src/box/identifier.c | 51 ++++++++++-----------------------------------
> src/box/identifier.h | 13 ------------
> test/unit/vy_point_lookup.c | 2 --
> 4 files changed, 11 insertions(+), 57 deletions(-)
next prev parent reply other threads:[~2018-04-06 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 12:35 Vladislav Shpilevoy
2018-04-04 12:38 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-06 13:53 ` Vladimir Davydov [this message]
2018-04-07 20:34 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-10 10:37 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406135302.fhv6kn5e5k7v2gvk@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [PATCH 1/1] identifier: do not use ICU UConverter for checks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox