From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] rework SQL 'DROP' routine
Date: Thu, 5 Apr 2018 17:12:30 +0300 [thread overview]
Message-ID: <20180405141230.wxn565zan3cfcbps@tarantool.org> (raw)
In-Reply-To: <cover.1522769126.git.korablev@tarantool.org>
Hello Nikita,
On 03 апр 19:14, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3222-rework-drop
> Issue: https://github.com/tarantool/tarantool/issues/3222
>
> This small patch-set implements part of #3222 issue: rewrite functions
> implementing drop table and drop index in order to avoid using
> struct Table and its lookup in SQLite data-dictionary.
> However, as far as currently triggers aren't part of Tarantool's spaces,
> it is still required to use struct Table to drop them:
> triggers are held in _trigger space, which format is: ['name', 'sql'],
> i.e. there is no field for name of parent table. Hence, we are able
> to point out table's triggers only via accessing struct Table.
>
> Both patches are mainly about refactoring.
> First patch removes useless wrappers, obsolete SQLite specific functions
> and struct fields.
> Second one replaces usages of struct Table with struct space in drop
> routine, fixes codestyle, provides doxygen style comments.
>
> Nikita Pettik (2):
> sql: remove obsolete SQLite routine
> sql: rework 'DROP INDEX' and 'DROP TABLE' handling
Patchset looks perfect now, I've checked it into 2.0.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-04-05 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 16:14 [tarantool-patches] " Nikita Pettik
2018-04-03 16:14 ` [tarantool-patches] [PATCH 1/2] sql: remove obsolete SQLite routine Nikita Pettik
2018-04-03 17:54 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-04 18:09 ` n.pettik
2018-04-05 11:16 ` Vladislav Shpilevoy
2018-04-05 12:13 ` n.pettik
2018-04-05 13:28 ` Vladislav Shpilevoy
2018-04-03 16:14 ` [tarantool-patches] [PATCH 2/2] sql: rework 'DROP INDEX' and 'DROP TABLE' handling Nikita Pettik
2018-04-03 18:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-04 18:11 ` n.pettik
2018-04-05 11:20 ` Vladislav Shpilevoy
2018-04-05 14:12 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405141230.wxn565zan3cfcbps@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] rework SQL '\''DROP'\'' routine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox