[tarantool-patches] Re: [PATCH v2] sql: ban of REINDEX syntax

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello Ivan, Sasha.
On 04 апр 18:56, Alexander Turenko wrote:
> Kirill, can you catch this patch?
> 
> I gave my LGTM in the separate branch of this mail thread.
> 
> WBR, Alexander Turenko.
> 
> On Wed, Apr 04, 2018 at 06:42:10PM +0300, n.pettik wrote:
> > Hello. See only one minor remark. The rest seems OK to me.
> > 
> > > On 4 Apr 2018, at 15:30, Ivan Ilyin <vanyail@yandex.ru> wrote:
> > > 
> > > From: vanyail <vanyail@yandex.ru>
> > > 
> > > This change removes REINDEX from keywords and also disables tests
> > > which were using this syntax.
> > > 
> > > This patch affects only parser, REINDEX implementation still exists,
> > > because it is planned to be fixed and enabled in the scope of #3195.
> > > 
> > > Note that REINDEX keyword is still in '%fallback' directive in
> > > 'parse.y'. Reserved keywords included there to avoid situation when
> > > a keyword has no usages within 'parse.y' file.
> > > 
> > > Fixes #2174
> > > branch: https://github.com/tarantool/tarantool/tree/gh-2174-ban-reindex-syntax
> > > issue: https://github.com/tarantool/tarantool/issues/2174
The error message confuses me as well. But let's go with it, since we'll
probably re-enable REINDEX soon.

I've checked your patch in to 2.0.

--
Regards, Kirill Yukhin

> > > ---
> > > src/box/sql/parse.c                              | 1797 +++++++++++-----------
> > > src/box/sql/parse.y                              |   18 +-
> > > test/sql-tap/gh-2174-ban-reindex-syntax.test.lua |   29 +
> > > test/sql-tap/gh2130-index-refer-table.test.lua   |   23 +-
> > > test/sql-tap/misc3.test.lua                      |   73 +-
> > > test/sql-tap/suite.ini                           |    2 +
> > > 6 files changed, 980 insertions(+), 962 deletions(-)
> > > create mode 100755 test/sql-tap/gh-2174-ban-reindex-syntax.test.lua
> > > 
> > > ...