From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/4] sql: refactor insertion and lua
Date: Thu, 5 Apr 2018 14:43:05 +0300 [thread overview]
Message-ID: <20180405114305.oefl47b4hky7xlty@tarantool.org> (raw)
In-Reply-To: <cover.1522769319.git.v.shpilevoy@tarantool.org>
Hello Vlad,
On 03 апр 18:34, Vladislav Shpilevoy wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gh-2618-preliminary-patches
> Issue: https://github.com/tarantool/tarantool/issues/2618
>
> The patchset consists of patches preliminary to SQL IProto
> "last updated tuple" introduction. It is possible, that its
> implementation plan will be changed several times, but this
> patchset looks useful even with no IProto "last updated tuple".
>
> 1) The patch does SQL INSERT/UPDATE refactoring by removal of 2
> unused VDBE parameters, and by restyling of final insertion
> opcodes generator: sqlite3CompleteInsertion.
>
> 2) The patch does refactoring of Lua SQL executor, that is
> extremely overengineered now.
>
> Vladislav Shpilevoy (4):
> sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace]
> sql: remove unused error codes, use enum instead of defines
> sql: simplify lua SQL executor
> sql: remove useless branching in insertOrReplace
The patchset LGTM. I've comitted it to 2.0
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-04-05 11:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 15:34 [tarantool-patches] " Vladislav Shpilevoy
2018-04-03 15:34 ` [tarantool-patches] [PATCH 1/4] sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace] Vladislav Shpilevoy
2018-04-03 23:01 ` [tarantool-patches] " n.pettik
2018-04-04 10:26 ` Vladislav Shpilevoy
2018-04-04 11:51 ` n.pettik
2018-04-04 14:48 ` n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 2/4] sql: remove unused error codes, use enum instead of defines Vladislav Shpilevoy
2018-04-03 23:01 ` [tarantool-patches] " n.pettik
2018-04-04 10:26 ` Vladislav Shpilevoy
2018-04-04 11:30 ` n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 3/4] sql: simplify lua SQL executor Vladislav Shpilevoy
2018-04-03 23:02 ` [tarantool-patches] " n.pettik
2018-04-03 15:34 ` [tarantool-patches] [PATCH 4/4] sql: remove useless branching in insertOrReplace Vladislav Shpilevoy
2018-04-03 23:01 ` [tarantool-patches] " n.pettik
2018-04-05 11:43 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405114305.oefl47b4hky7xlty@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 0/4] sql: refactor insertion and lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox