From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: vanyail <vanyail@yandex.ru>, "n.pettik" <korablev@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2] sql: ban of REINDEX syntax
Date: Wed, 4 Apr 2018 18:56:16 +0300 [thread overview]
Message-ID: <20180404155616.g6ew4uqc3imouawd@tkn_work_nb> (raw)
In-Reply-To: <372ED065-AD77-48BE-A098-CFB74EF893A2@tarantool.org>
Kirill, can you catch this patch?
I gave my LGTM in the separate branch of this mail thread.
WBR, Alexander Turenko.
On Wed, Apr 04, 2018 at 06:42:10PM +0300, n.pettik wrote:
> Hello. See only one minor remark. The rest seems OK to me.
>
> > On 4 Apr 2018, at 15:30, Ivan Ilyin <vanyail@yandex.ru> wrote:
> >
> > From: vanyail <vanyail@yandex.ru>
> >
> > This change removes REINDEX from keywords and also disables tests
> > which were using this syntax.
> >
> > This patch affects only parser, REINDEX implementation still exists,
> > because it is planned to be fixed and enabled in the scope of #3195.
> >
> > Note that REINDEX keyword is still in '%fallback' directive in
> > 'parse.y'. Reserved keywords included there to avoid situation when
> > a keyword has no usages within 'parse.y' file.
> >
> > Fixes #2174
> > branch: https://github.com/tarantool/tarantool/tree/gh-2174-ban-reindex-syntax
> > issue: https://github.com/tarantool/tarantool/issues/2174
> > ---
> > src/box/sql/parse.c | 1797 +++++++++++-----------
> > src/box/sql/parse.y | 18 +-
> > test/sql-tap/gh-2174-ban-reindex-syntax.test.lua | 29 +
> > test/sql-tap/gh2130-index-refer-table.test.lua | 23 +-
> > test/sql-tap/misc3.test.lua | 73 +-
> > test/sql-tap/suite.ini | 2 +
> > 6 files changed, 980 insertions(+), 962 deletions(-)
> > create mode 100755 test/sql-tap/gh-2174-ban-reindex-syntax.test.lua
> >
> > ...
next prev parent reply other threads:[~2018-04-04 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 12:30 [tarantool-patches] " Ivan Ilyin
2018-04-04 12:54 ` [tarantool-patches] " Alexander Turenko
2018-04-04 15:42 ` n.pettik
2018-04-04 15:56 ` Alexander Turenko [this message]
2018-04-05 12:19 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404155616.g6ew4uqc3imouawd@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vanyail@yandex.ru \
--subject='[tarantool-patches] Re: [PATCH v2] sql: ban of REINDEX syntax' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox