Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Gleb <gleb-skiba@mail.ru>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: remove support of partial indexes
Date: Thu, 29 Mar 2018 13:10:29 +0300	[thread overview]
Message-ID: <20180329101028.kutvgeay23dtqgpq@tkn_work_nb> (raw)
In-Reply-To: <1521937705-8170-1-git-send-email-gleb-skiba@mail.ru>

Hi, Gleb!

Please, squash your two commits into one and resend the patch.

WBR, Alexander Turenko.

On Sun, Mar 25, 2018 at 03:28:25AM +0300, Gleb wrote:
> Issue from https://github.com/tarantool/tarantool/issues/2165.
> Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes.

Place it under --- mark.

> Remove support partial indexes.
> Add test which check inaccessibility of partial index syntax.
> Comment tests which use partial index, they can be uncomment when partial index will be available.

The line length exceeds 72 symbols.

> Fixed comments as per review.

That should not be part of the commit message.

> 
> Fixes #2165
> ---

Here you should place issue/branch names, changelog and other things
that should not be part of the commit.

>  src/box/sql/build.c              |  11 +-
>  src/box/sql/parse.c              | 205 +++++++++---------
>  src/box/sql/parse.y              |   2 +-
>  test/sql-tap/analyze9.test.lua   |  18 +-
>  test/sql-tap/autoindex4.test.lua |   5 +-
>  test/sql-tap/fkey1.test.lua      |   1 -
>  test/sql-tap/index6.test.lua     | 437 +++++++++++++++++++--------------------
>  test/sql-tap/suite.ini           |   1 +
>  8 files changed, 333 insertions(+), 347 deletions(-)
>
> ...
>
> diff --git a/test/sql-tap/analyze9.test.lua b/test/sql-tap/analyze9.test.lua
> index 472bad7..206ae16 100755
> --- a/test/sql-tap/analyze9.test.lua
> +++ b/test/sql-tap/analyze9.test.lua
> ...
> @@ -1177,9 +1172,9 @@ test:do_execsql_test(
>  --    [[
>  --        EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE d IS NOT NULL AND a=0 AND b=0 AND c=10;
>  --    ]], {
> ---        -- <17.6>
> +          -- <17.6>
>  --        0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX I2 (C=? AND D>?)"
> ---        -- </17.6>
> +          -- </17.6>
>  --    })
>  

Use -- *at start* of each line for the entire block or --[[ ... ]]--.
I'm about '<17.6>' lines.

> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 0bc9e83..d6ce75e 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -3,3 +3,4 @@ core = app
>  description = Database tests with #! using TAP
>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>  is_parallel = True
> +disabled = index6.test.lua;

Space before ';' is needed according to [1]. Write a comment with the
issue re partial index enabling (#2626), please.

> -- 
> 2.7.4
> 

       reply	other threads:[~2018-03-29 10:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1521937705-8170-1-git-send-email-gleb-skiba@mail.ru>
2018-03-29 10:10 ` Alexander Turenko [this message]
2018-03-29 10:14   ` [tarantool-patches] " GLEB SKIBA
2018-03-29 10:21     ` Alexander Turenko
2018-03-29 10:42       ` [tarantool-patches] " GLEB SKIBA
2018-03-29 10:54         ` [tarantool-patches] " Alexander Turenko
2018-03-29 10:58 [tarantool-patches] " Gleb
2018-04-02 12:31 ` [tarantool-patches] " Alexander Turenko
2018-04-03 11:42 [tarantool-patches] " Gleb
2018-04-04 15:27 ` [tarantool-patches] " n.pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329101028.kutvgeay23dtqgpq@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=gleb-skiba@mail.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: remove support of partial indexes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox